Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect fix: alingments->alinements #1143

Closed
cmdcolin opened this issue Nov 5, 2024 · 3 comments · Fixed by #1146
Closed

Incorrect fix: alingments->alinements #1143

cmdcolin opened this issue Nov 5, 2024 · 3 comments · Fixed by #1146
Labels
bug Not as expected

Comments

@cmdcolin
Copy link

cmdcolin commented Nov 5, 2024

alingments is currently being corrected to alinements but it should be alignments

error: `alingments` should be `alinements`
  --> ./test.txt:1:1
  |
1 | alingments
  | ^^^^^^^^^^
  |

epage added a commit to epage/typos that referenced this issue Nov 5, 2024
@epage epage added the bug Not as expected label Nov 5, 2024
@epage
Copy link
Collaborator

epage commented Nov 5, 2024

Hmm, this is an interesting case. We try to keep our dictionary agnostic of english dialects by correcting to the closest variant of a word and then switching that to a specific dialect if requested.

varcon has this entry

# alignment <verified> (level 20)
A B: alignment / AV: alinement
A B: alignments / AV: alinements
A B: alignment's / AV: alinement's

Regarding level 20

The levels generally mean the following:
<= 35: Very common word
<= 70: Can be found in the dictionary
80: Likely a valid word, can likely be found in an
unabridged dictionary

80: May not even be a legal word

As of version 5.0, most
clusters with headwords in common usage (SCOWL level 35 and below)
should now be checked, as well as many others.

Regarding <verified>

Earlier versions of varcon contained numerous errors. With version
5.0 massive effort has been made to correct many of these errors.
Clusters that have undergone some form of verification (and likely
correction) are marked with "".

As for AV

A: American

V: seldom used variant

However, visually, I see that alignment is closer than alinement to the users intent but for some reason our word similarity check is saying alinement is a better fit (a letter replacement vs a letter swap). I'll have to check their scores more directly and see if there is any automated tweaking to be made or if I'll have to hack this.

@epage
Copy link
Collaborator

epage commented Nov 5, 2024

Huh, looks like we ran into this with alinging and put a hack in. Doing the same.

@cmdcolin
Copy link
Author

cmdcolin commented Nov 6, 2024

thanks for checking into this! looks like i reported that one too awhile back...turns out i run into the word alignment a lot :)

#823 (comment)

@epage epage closed this as completed in 5afabf7 Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Not as expected
Projects
None yet
2 participants