Don't Change Typos inside of URL

[Skylion007]

I tried to apply this automatically to some repos and it tried to fix some URLs. Obviously, that won't work if the original URL has a typo and the URL is not under your control. Absolute HTTPS URLs should not be changed or at least there should be an option to disable the changing of them.

[epage]

Things that might be useful from another tool

• email handling: https://github.com/client9/misspell/blob/master/notwords.go#L66
• host handling: https://github.com/client9/misspell/blob/master/notwords.go#L71
• escape sequences: https://github.com/client9/misspell/blob/master/notwords.go#L77
• urls: https://github.com/client9/misspell/blob/master/url.go

[Skylion007]

RFC 5322 <http://www.ietf.org/rfc/rfc5322.txt> ie: http://emailregex.com/ exists

…

On Thu, Jun 17, 2021 at 3:42 PM Ed Page ***@***.***> wrote: Things that might be useful from another tool - email handling: https://github.com/client9/misspell/blob/master/notwords.go#L66 - host handling: https://github.com/client9/misspell/blob/master/notwords.go#L71 - escape sequences: https://github.com/client9/misspell/blob/master/notwords.go#L77 - urls: https://github.com/client9/misspell/blob/master/url.go — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#288 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAPVMX4FZVRX3MQI5B6PQHLTTJF35ANCNFSM464JUMBQ> .

[Skylion007]

Even worse, I found it mangles go get urls for people who have intentional typos in their usernames. This breaks the repo. Furthermore, that regex may not catch it. Here is a diff in a go repo I tried this on.

-       "github.com/Unknwon/goconfig"
+       "github.com/Unknown/goconfig"