-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Base64 strings should not be checked for typos #327
Comments
We have base64 detection; to understand why its not working in your case, I'd need to see the entire file. You can work around this with per-file settings though if we have a known extension, I think its worth baking it directly into typos |
This is the file: https://github.com/tokio-rs/axum/blob/7cf8dafdce26276b1969111dbbf034bb98786e30/examples/self_signed_certs/cert.pem I used |
I guess base64 detection might not trigger on these lines because they happen to only contain alphanumeric characters? |
For our base64 detection to work, it needs to be 90+ characters and have the appropriate padding. The line splitting is what I think is messing up the detection. I'm working on making all cert files excluded by default |
Binaries for v1.1.5 should be building right now which should exclude cert file content by default. I've added a |
I just got lots of errors for a base64-encoded TLS certificate. Typos should probably detect base64 strings and not check them, or just skip
.pem
files entirely :)The text was updated successfully, but these errors were encountered: