Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missed typo that is in the list #411

Closed
afranke opened this issue Jan 26, 2022 · 2 comments · Fixed by #412
Closed

Missed typo that is in the list #411

afranke opened this issue Jan 26, 2022 · 2 comments · Fixed by #412
Labels
bug Not as expected

Comments

@afranke
Copy link

afranke commented Jan 26, 2022

In matrix-org/matrix-spec-proposals#3658 (comment) the misspelt word ("defintions" instead of "definitions") was not caught, but it is already in words.csv.

CC @aaronraimist who added the CI workflow.
@epage
Copy link
Collaborator

epage commented Jan 26, 2022

Thanks for reporting this!

It looks like our tokenizer has a bug where its incorrectly ending at templates. In this case, its ending at:

Some API endpoints may allow or require the use of `POST` requests
without a transaction ID. Where this is optional, the use of a `PUT`
request is strongly recommended.

{{% http-api spec="client-server" api="versions" %}}

(I used the --identifiers flag to discover this)

@epage epage added the bug Not as expected label Jan 26, 2022
epage added a commit to epage/typos that referenced this issue Jan 26, 2022
@epage
fix(parser): Don't stop on almost-printfs
3c78d65 
When we added support for printf interopolation, we had to adjust our
separator matching to not eat the start of printf interpolation.

When doing so, I overlooked the need to still eat it in the catch-all.
If we don't, we then try to read `%` as part of the identifier and bail
out early.

Fixes crate-ci#411
@epage epage mentioned this issue Jan 26, 2022
Merged
@epage
Copy link
Collaborator

epage commented Jan 26, 2022

v1.3.8 is released with the fix

This was referenced Jan 26, 2022
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Not as expected
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(parser): Don't stop on almost-printfs epage/typos
2 participants
@epage @afranke