-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
False positive in filename, hugo markdown custom shortcode #485
Comments
Could you include a copyable version of one of those lines? We have GUID detection; my guess is its related to #481 |
Hi @epage
It also appears to have problems with (oddly terminated) base64 strings:
Thanks |
Was able to confirm, this is a duplicate of #481 |
Actually, going to re-open this because this has a slightly different root cause. For As a workaround, if With the backtracking requirements needed to make this work, I'm concerned we don't have a viable way to directly fix this. In #484, we are talking about a heuristic for discarding words which might be a viable route for working around this. |
Previously, we bailed out if the string is too short (<90) and there weren't non-alpha-base64 bytes present. What we ignored were the padding bytes. We key off of padding bytes to detect that a string is in fact base64 encoded. Like the other cases, there can be false positives but those strings should show up elsewhere or the compiler will fail. This was called out in crate-ci#485
Previously, we bailed out if the string is too short (<90) and there weren't non-alpha-base64 bytes present. What we ignored were the padding bytes. We key off of padding bytes to detect that a string is in fact base64 encoded. Like the other cases, there can be false positives but those strings should show up elsewhere or the compiler will fail. This was called out in crate-ci#485
v1.8.0 is released with a fix for the base64 strings |
Thanks @epage ! Yes it's a tough problem to generalise over arbitrary code. Likely an impossible problem. I guess the best thing is to cover 99% of ground and rely on configuration to work around edge cases when there's no good solution. In my case I worked around it with a
It's a hack but I'm building again. |
Hi,
I receive the following false positive -- typos seems to be reading (custom) image tag filenames, matching on
ba
.Thanks!
Callan
PS: Thanks for such useful software; I use it as part of the build chain for my blog.
The text was updated successfully, but these errors were encountered: