-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement sarif format reporter #1047
Conversation
c22c553
to
50550f1
Compare
@epage Could you please approve the workflow run to see if anything broken by this? |
Pull Request Test Coverage Report for Build 9723606862Details
💛 - Coveralls |
1d021ad
to
f0a456a
Compare
@epage I have resolved the conflict. |
Sorry for the delays as I am slowly working through my backlog. It would help if the commits were cleaned up to present this how you want it reviewed and merged. It would also be good for us to have a test for this, likely among our end-to-end tests. |
linter warning resolved |
I suppose I could write some integration tests, but I'm not quite sure where the old tests are located, is there any architecture I could reuse? |
I have added a test |
Sorry that I've fallen behind and not been able to get back to this yet. I did want to quickly note that I just noticed the I wonder if github has integration for that so people get diffs in the post with the possibility of making a commit right from the review. Note: I would not block merging this PR on getting that to work |
b6a807e
to
9b227c8
Compare
|
311679f
to
6390844
Compare
@Zxilly mind doing a pass over of my changes? |
Look good to me, maybe we can add some cjk char to testcase? |
Closes: #594
I asked earlier if anyone had already worked on this feature and got no reply #594 (comment) , so I added this implementation myself.
But as I declared, I'm not a professional rust developer, so this patch obviously contains a lot of problems caused by a lack of understanding of rust, such as
.unwrap
abuse, since I'm not sure how to properly convertError
toio::Error
.I enabled
Allow edits by maintainers
, so if you have any suggestions for syntax changes, please push them directly to the corresponding repository branch, thanks!