Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

action: Support curl or wget, not just wget #1125

Closed
wants to merge 1 commit into from

Conversation

notpeter
Copy link

@notpeter notpeter commented Oct 17, 2024

This should allow the GitHub action to support platforms that have curl or wget.

At Zed we use a similar approach for our install script and have had good results.

This adds support for MacOS runners, but it should also fix for Alpine runners that don't have GNU wget (they ship the busybox wget clone) but do have curl.

P.S. I <3 typos. Someone even took typos-lsp and packaged it as a Zed Typos Extension

@notpeter notpeter changed the title Support curl or wget, not just wget action: Support curl or wget, not just wget Oct 17, 2024
@epage
Copy link
Collaborator

epage commented Oct 18, 2024

#771 and #772 were closed for finishing the conversation in #769 before moving on to implementation. Following suit here per our contributing guidelines

Already have an idea? It might be good to first create an issue to propose it so we can make sure we are aligned and lower the risk of having to re-work some of it and the discouragement that goes along with that.

@epage epage closed this Oct 18, 2024
@notpeter notpeter deleted the curl_or_wget branch October 18, 2024 20:22
@notpeter
Copy link
Author

notpeter commented Oct 18, 2024

It's your project, do as you wish.

@epage
Copy link
Collaborator

epage commented Oct 24, 2024

@notpeter I meant "...in favor of finishing the conversation in...". Sorry I wasn't clear.

For me, use cases are important for development. In #769, people were basically saying "because" without clarifying why this is so important. I was looking for more information on that, rather than more solutions. If something is spinning in a circle without progress, there isn't much to be done. This wasn't in "spite" or to "threaten" but to communicate where this was at.

As for your PR, it is a matter of people not following guidelines. I ask that we discuss your motivation in the issue, before a PR is made. In your case, you are using Mac runners. I would want to better understand why that is important, the underlying motivation, and what the capabilities are of the platform (commands and what they support, how others can be installed, and the problems with that).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GH Action does not work with Alpine
2 participants