Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: no longer ignore unused method lints #80

Merged
merged 2 commits into from
Jun 22, 2024
Merged

chore: no longer ignore unused method lints #80

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cd40fd4
chore: no longer ignore unused method lints
kevaundray Jun 22, 2024
6dbe100
chore: remove ignore linters for constants
kevaundray Jun 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions api_eip7594.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import (
kzgmulti "github.com/crate-crypto/go-eth-kzg/internal/kzg_multi"
)

//lint:ignore U1000 still fleshing out the API
func (ctx *Context) ComputeCellsAndKZGProofs(blob *Blob, numGoRoutines int) ([CellsPerExtBlob]*Cell, [CellsPerExtBlob]KZGProof, error) {
polynomial, err := DeserializeBlob(blob)
if err != nil {
Expand All @@ -24,7 +23,6 @@ func (ctx *Context) ComputeCellsAndKZGProofs(blob *Blob, numGoRoutines int) ([Ce
return ctx.computeCellsAndKZGProofsFromPolyCoeff(polyCoeff, numGoRoutines)
}

//lint:ignore U1000 still fleshing out the API
func (ctx *Context) computeCellsAndKZGProofsFromPolyCoeff(polyCoeff []fr.Element, _ int) ([CellsPerExtBlob]*Cell, [CellsPerExtBlob]KZGProof, error) {
// Partition the extended roots to form cosets
cosets := partition(ctx.domainExtended.Roots, scalarsPerCell)
Expand Down Expand Up @@ -64,7 +62,6 @@ func (ctx *Context) computeCellsAndKZGProofsFromPolyCoeff(polyCoeff []fr.Element
return Cells, serializedProofs, nil
}

//lint:ignore U1000 still fleshing out the API
func (ctx *Context) RecoverCellsAndComputeKZGProofs(cellIDs []uint64, cells []*Cell, _proofs []KZGProof, numGoRoutines int) ([CellsPerExtBlob]*Cell, [CellsPerExtBlob]KZGProof, error) {
// Check each proof can be deserialized
// TODO: This seems somewhat useless as we should not be calling this method with proofs
Expand Down Expand Up @@ -134,7 +131,6 @@ func (ctx *Context) RecoverCellsAndComputeKZGProofs(cellIDs []uint64, cells []*C
return ctx.computeCellsAndKZGProofsFromPolyCoeff(polyCoeff, numGoRoutines)
}

//lint:ignore U1000 still fleshing out the API
func (ctx *Context) VerifyCellKZGProof(commitment KZGCommitment, cellID uint64, cell *Cell, proof KZGProof) error {
// Check if the cell ID is less than CellsPerExtBlob
if cellID >= CellsPerExtBlob {
Expand Down Expand Up @@ -165,7 +161,6 @@ func (ctx *Context) VerifyCellKZGProof(commitment KZGCommitment, cellID uint64,
return kzgmulti.VerifyMultiPointKZGProof(commitmentG1, proofG1, cosetEvals, cosets[cellID], ctx.openKey)
}

//lint:ignore U1000 still fleshing out the API
func (ctx *Context) VerifyCellKZGProofBatch(rowCommitments []KZGCommitment, rowIndices, columnIndices []uint64, cells []*Cell, proofs []KZGProof) error {
// Check that all components in the batch have the same size, expect the rowCommitments
batchSize := len(rowIndices)
Expand Down
4 changes: 0 additions & 4 deletions serialization.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,16 +43,12 @@ const scalarsPerCell = 64

// expansionFactor is the factor by which the number of
// scalars in a blob is expanded to create an extended blob.
//
//lint:ignore U1000 still fleshing out the API
const expansionFactor = 2

// scalarsPerExtBlob is the number of scalars in an extended blob.
//
// An extended blob is a blob that has been evaluated at more points than is needed
// to uniquely determine the polynomial its corresponding polynomial.
//
//lint:ignore U1000 still fleshing out the API
const scalarsPerExtBlob = expansionFactor * ScalarsPerBlob

type (
Expand Down
Loading