Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

duplicated extension status: Add the same test as for go-verkle #51

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

gballet
Copy link
Contributor

@gballet gballet commented Jul 1, 2022

No description provided.

@gballet
Copy link
Contributor Author

gballet commented Jul 2, 2022

the test fails, because it tests for an agreement with the output of go-verkle, thus demonstrating the problem

@kevaundray
Copy link
Contributor

Thanks for the PR, currently checking if this deduplication can be introduced after we've produced the proof of absence stems instead of introducing an edge case when collecting the proof of absence stems

- sort keys before creating prover queries and then compress the verification hint for extension statuses with None
- Add methods to compress and decompress the VerificationHint. Also sort the keys and values according to the keys before the verifier checks the proof.
@gballet
Copy link
Contributor Author

gballet commented Jul 11, 2022

I'm getting the following stacktrace after upgrading to that branch:

thread 'main' panicked at 'called `Option::unwrap()` on a `None` value', /home/gballet/.cargo/git/checkouts/rust-verkle-93a9500a914bcd55/b05a8e9/verkle-trie/src/proof.rs:151:50
stack backtrace:
   0: rust_begin_unwind
             at /rustc/db9d1b20bba1968c1ec1fc49616d4742c1725b4b/library/std/src/panicking.rs:498:5
   1: core::panicking::panic_fmt
             at /rustc/db9d1b20bba1968c1ec1fc49616d4742c1725b4b/library/core/src/panicking.rs:107:14
   2: core::panicking::panic
             at /rustc/db9d1b20bba1968c1ec1fc49616d4742c1725b4b/library/core/src/panicking.rs:48:5
   3: core::option::Option<T>::unwrap
             at /rustc/db9d1b20bba1968c1ec1fc49616d4742c1725b4b/library/core/src/option.rs:746:21
   4: verkle_trie::proof::VerificationHint::decompress
             at /home/gballet/.cargo/git/checkouts/rust-verkle-93a9500a914bcd55/b05a8e9/verkle-trie/src/proof.rs:151:31
   5: verkle_trie::proof::VerkleProof::check
             at /home/gballet/.cargo/git/checkouts/rust-verkle-93a9500a914bcd55/b05a8e9/verkle-trie/src/proof.rs:355:9
   6: verkle_block_sample::main
             at ./src/main.rs:85:24
   7: core::ops::function::FnOnce::call_once
             at /rustc/db9d1b20bba1968c1ec1fc49616d4742c1725b4b/library/core/src/ops/function.rs:227:5
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants