Conversation
fca6bb1 to
530afaf
Compare
Member
Author
^^ @proddata can decide if he wants to merge it, or not. If yes, please do on your own behalf. Thanks! |
4476481 to
8506ae4
Compare
Member
Author
It certainly makes a difference, for example here. You have to decide if you want it or not.
Before/AfterA picture says... /cc @msbt, @matkuliak, @simonprickett, @karynzv, @hammerhead, @hlcianfagna, @proddata, @widmogrod |
- Uses beta version of next generation theme. - Increases toctree maxdepth to 4.
Member
Author
|
Hi again. It looks like both |
proddata
approved these changes
Aug 6, 2024
Member
Author
|
Thanks for merging! |
Contributor
I just followed your orders :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


About
This RTD build gives you the chance to preview and review the documentation, using a pre-release of the modernized crate-docs-theme, based on sphinx-basic-ng/Furo.
Note
Also increases toctree maxdepth to 4. That may be good, or not, or it doesn't matter at all. Before, it was 2. See crate/crate-docs-theme#515.
Preview
https://crate-cloud--79.org.readthedocs.build/en/79/
Thoughts
It doesn't look too bad. Thanks for your fixes, @msbt!
If you agree, and don't object a slight anomaly in appearance, because other projects are not using the modernized theme yet, you are free to merge it at your disposal.
If you can spot any flaws or other more serious regressions, or just little ones, please let us know about them!
References
sphinx-basic-ngcrate-docs-theme#390/cc @surister, @simonprickett, @kneth