Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve sphinx-copybutton: Enable copying empty lines #288

Merged
merged 1 commit into from
Jun 17, 2021

Conversation

amotl
Copy link
Member

@amotl amotl commented May 27, 2021

Problem

Currently, empty lines in code snippets will not get copied to the clipboard when using sphinx-copybutton. For example, see https://crate.io/docs/python/en/latest/sqlalchemy.html#tables.

Solution

By following up on executablebooks/sphinx-copybutton#84, this patch will resolve #287.

Attention

For this to work, executablebooks/sphinx-copybutton#127 will have to be integrated and released beforehand.

@amotl amotl requested review from nomicode, msbt and proddata May 27, 2021 19:45
@amotl amotl force-pushed the amo/snippets-copy-empty-lines branch from de6c568 to b0a2675 Compare May 27, 2021 19:46
@amotl amotl changed the title Improve code snippet copying by also copying empty lines Improve sphinx-copybutton: Enable copying empty lines May 27, 2021
@amotl amotl force-pushed the amo/snippets-copy-empty-lines branch from b0a2675 to 02df24c Compare June 17, 2021 17:13
@amotl
Copy link
Member Author

amotl commented Jun 17, 2021

Hi again,

@choldgraf handled our contribution executablebooks/sphinx-copybutton#127 very kindly and converged it, accompanied by other improvements, into a new release sphinx-copybutton==0.3.3 at the speed of light. Thank you very much!

This patch will update the theme to use the most recent version of sphinx-copybutton.

With kind regards,
Andreas.

@amotl amotl requested a review from seut June 17, 2021 17:14
@amotl amotl marked this pull request as ready for review June 17, 2021 17:14
Copy link
Member

@seut seut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@amotl amotl merged commit 1b00b5e into main Jun 17, 2021
@amotl amotl deleted the amo/snippets-copy-empty-lines branch June 17, 2021 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sphinx-copybutton does not copy empty lines
2 participants