Add modern components from the Sphinx ecosystem#378
Conversation
|
Hello @amotl this is great, thank you! |
That would not have been intended. Please add an inline comment on the PR where you discovered this spot. |
d86eb2a to
1ba3b76
Compare
docs/myst-overview.md
Outdated
| ### Inline quotes / citations | ||
|
|
||
| > This text should be quoted. |
There was a problem hiding this comment.
It looks like the Markdown/MyST markup instruction to quote/cite text does not render properly yet. /cc @msbt
There was a problem hiding this comment.
@amotl do we have an example on how that's supposed to look like? We probably need to remove some css from the original theme to make this work
There was a problem hiding this comment.
Not sure for our theme, but in general:
- https://pradyunsg.me/furo/reference/text-formatting/#text-formatting (The "This is blockquoted text." at the bottom)
- https://myst-parser.readthedocs.io/en/v0.13.5/using/syntax.html#math-in-other-block-elements ("A block quote $a=1
$")
There was a problem hiding this comment.
Exactly. It is written like
> Franz jagt im komplett verwahrlosten Taxi quer durch Bayern.
and usually renders like
Franz jagt im komplett verwahrlosten Taxi quer durch Bayern.
There was a problem hiding this comment.
There was a problem hiding this comment.
Looks good, I think you found the right spot, thanks. 🙇
There was a problem hiding this comment.
@matkuliak @amotl https://github.com/crate/crate-docs-theme/blob/main/src/crate/theme/rtd/crate/static/css/crateio-rtd.css#L27-L31 is indeed the main issue, if we remove those lines, the quote works. But if you have a paragraph wrapped in there, we might also need to override the margin-bottom, else it won't be centered vertically:
Should I whip something up? And can you check if we're actually using the current blockquote somewhere in the docs @matkuliak?
There was a problem hiding this comment.
Should I whip something up?
Please go ahead. Thanks!
There was a problem hiding this comment.
Thank you for submitting GH-380, aiming to fix this.
There was a problem hiding this comment.
I think this works well now, right?
- https://crate-docs-theme--378.org.readthedocs.build/en/378/rst/misc.html
- https://crate-docs-theme--378.org.readthedocs.build/en/378/myst/misc.html
Thank you again.
- myst-parser - sphinx-design - sphinx-inline-tabs - sphinx-subfigure - sphinx-togglebutton - sphinxcontrib-mermaid
- myst-parser - sphinx-design - sphinx-inline-tabs - sphinx-subfigure - sphinx-togglebutton - sphinxcontrib-mermaid
| Todo items | ||
| ========== | ||
| .. todo:: | ||
|
|
||
| Foo bar baz. |
There was a problem hiding this comment.
Apparently, the .. todo directive renders itself with a bit too much of a left padding or margin. Maybe we can do something about it on a future iteration. It is not too important right now.
-- https://crate-docs-theme--378.org.readthedocs.build/en/378/rst/misc.html
-- https://crate-docs-theme--378.org.readthedocs.build/en/378/myst/misc.html
- The legacy feature gallery exclusively uses reStructuredText. - The modernized feature gallery demonstrates both reStructuredText and Markedly Structured Text syntax.



About
This patch adds a few modern components from the Sphinx ecosystem to the theme, and demonstrates how they are used. Thanks to all the authors for your excellent work.
Preview
The preview of the demonstration pages can be inspected at RTD: CrateDB docs theme » Preview. There is a dedicated section demonstrating how to use the corresponding modern Sphinx components, elements, and styles.
https://crate-docs-theme--378.org.readthedocs.build/en/378/#modernized