Refactor feedback and version chooser components #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amotl
force-pushed
the
amo/refactor-feedback
branch
from
d0d6a96
to
ad5813f
Compare
This makes the version chooser also work on local builds.
amotl
force-pushed
the
amo/refactor-feedback
branch
from
ecdb0ea
to
6fa5f15
Compare
amotl
changed the title
amotl
force-pushed
the
amo/refactor-feedback
branch
2 times, most recently
from
047a3af
to
e15713b
Compare
amotl
force-pushed
the
amo/refactor-feedback
branch
from
e15713b
to
2cd8c5d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
Use separate files for defining the feedback component at the bottom of the page, and the version chooser at the top of the page.
Details
It aims to set the stage for GH-385, which actually changes the page layout. This patch only moves code around, and starts building upon modern styling components, without changing the visual appearance too much.
Preview
https://crate-docs-theme--384.org.readthedocs.build/en/384/
References
make dev:/src, and non-rST files crate-docs#99 will make it easier to work on such refactorings, by also triggering automatic rebuilds on changes to HTML, CSS, and JS files.