-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Navigation: Add header menu items from website #534
Conversation
dd9dd5e
to
67f0fe0
Compare
1b354c8
to
c6f66a7
Compare
Hi @msbt, rough draft of the navigation similar to our main site. I'm not really familiar with all the css in our docs, it's split into a couple of files so I mostly made new classes. Let me know if I should shuffle some stuff elsewhere. Thanks! |
Thanks. Isn't this supposed to go into some SSI snippet? |
Not sure. After pushing, @msbt let me know about https://cratedb.com/_hcms/api/navi-header. That was previously used as a dynamic source for the list through ESI. So going to switch to that probably |
1e42b2c
to
ad9383c
Compare
Can you add this to https://cratedb.com/_hcms/api/navi-header instead, @msbt? 🙏 |
@amotl I'll give it a go, might take some time though |
@amotl I've implemented the current navigation as fallback and reintroduced the esi's, are we happy with it? PR link is to the latest status (https://crate-docs-theme--534.org.readthedocs.build/en/534/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it will be good to merge and release, and applying "ack by timeout" will not cause too much harm, even despite its duration was a bit short here. If other reviewers can spot any annoyances, or wish to add more items, relevant suggestions will be considered in retrospective. |
Summary of the changes / Why this is an improvement
We want to bring the top navigation from main page to the docs:
Preview
https://crate-docs-theme--534.org.readthedocs.build/en/534/
cc @geragray