Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The linkcheck target is no longer run by make check #30

Closed
nomicode opened this issue Nov 4, 2020 · 0 comments · Fixed by #33
Closed

The linkcheck target is no longer run by make check #30

nomicode opened this issue Nov 4, 2020 · 0 comments · Fixed by #33
Labels
bug Something isn't working

Comments

@nomicode
Copy link
Contributor

nomicode commented Nov 4, 2020

see

crate-docs/src/rules.mk

Line 160 in e39edc6

# If you are having problems with the `linkcheck` target, you might

the html and linkcheck targets share the same rule but do not specify the "builder". by default html is used. so if you run the linkcheck target as currently defined, it will run sphinx-build with the default html builder

the fix is to pass in the builder using the name of the matched target, using syntax that evaluates to -b html or -b linkcheck (as appropriate)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Pass target (html or linkcheck) through to sphinx-build crate/crate-docs
1 participant
@nomicode