Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance: Add support for Python 3.11 #549

Merged
merged 1 commit into from
Mar 3, 2025
Merged

Maintenance: Add support for Python 3.11 #549

merged 1 commit into from
Mar 3, 2025

Conversation

amotl
Copy link
Member

@amotl amotl commented Sep 6, 2023

About

Make the operator support Python 3.11.

Blocked by

SStorm

This comment was marked as resolved.

@amotl

This comment was marked as resolved.

@SStorm

This comment was marked as resolved.

@amotl amotl force-pushed the collab/modernize branch 3 times, most recently from bcac5a6 to 7ede699 Compare June 3, 2024 19:26
@amotl

This comment was marked as resolved.

@amotl amotl force-pushed the collab/modernize branch from 7ede699 to 70432f6 Compare June 20, 2024 22:41
@amotl amotl changed the title Maintenance: Update to Python 3.11, and modernize dependencies Maintenance: Update to Python 3.11 Jun 20, 2024
@amotl amotl force-pushed the collab/modernize branch from 70432f6 to 79467c2 Compare June 20, 2024 22:41
@goat-ssh

This comment was marked as resolved.

@amotl

This comment was marked as resolved.

@amotl

This comment was marked as duplicate.

@amotl amotl changed the base branch from master to collab/update-mypy November 5, 2024 18:36
@amotl amotl force-pushed the collab/update-mypy branch from dfbe1ca to 7beaad8 Compare November 6, 2024 10:58
@amotl amotl force-pushed the collab/update-mypy branch 3 times, most recently from af30858 to 5d0ae35 Compare December 16, 2024 19:15
@amotl amotl force-pushed the collab/update-mypy branch from 5d0ae35 to 0f34067 Compare February 11, 2025 14:18
@amotl amotl force-pushed the collab/modernize branch 2 times, most recently from 6cecb4f to 553e58f Compare February 11, 2025 14:25
@amotl amotl requested review from Taliik, tomach and goat-ssh February 11, 2025 14:28
@amotl amotl marked this pull request as ready for review February 11, 2025 14:28
@amotl amotl changed the title Maintenance: Update to Python 3.11 Maintenance: Add support for Python 3.11 Feb 11, 2025
@amotl amotl force-pushed the collab/update-mypy branch from 737a1b8 to 2e687fc Compare February 14, 2025 09:17
Base automatically changed from collab/update-mypy to master February 14, 2025 10:15
@amotl amotl requested review from plaharanne and removed request for Taliik and goat-ssh February 14, 2025 10:17
@amotl amotl force-pushed the collab/modernize branch 3 times, most recently from 258a667 to 8d50802 Compare February 17, 2025 12:35
Copy link
Contributor

@plaharanne plaharanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me, but I would rather let @tomach approve it, as he worked on the other python upgrades, etc.

@amotl amotl requested review from plaharanne and SStorm March 3, 2025 09:22
@amotl
Copy link
Member Author

amotl commented Mar 3, 2025

Thanks. @tomach: Do you have any objections? 🙏

@tomach
Copy link
Contributor

tomach commented Mar 3, 2025

Do you have any objections?

@amotl No objections from my side, thanks a lot! just to clarify - are we planning to update the Dockerfile to Python 3.11 in a future PR? Right now, this ensures compatibility in CI but doesn’t impact the runtime environment right? or maybe we should also let the integration tests on k8s run with 3.11 here as a first step?

Copy link
Contributor

@tomach tomach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@amotl amotl merged commit 67bf7d6 into master Mar 3, 2025
8 checks passed
@amotl amotl deleted the collab/modernize branch March 3, 2025 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants