-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Client Tests: Update dependencies for Rust, using cargo update
#314
Conversation
tests/client_tests/rust/Cargo.lock
Outdated
source = "registry+https://github.com/rust-lang/crates.io-index" | ||
checksum = "282be5f36a8ce781fad8c8ae18fa3f9beff57ec1b52cb3de0789201425d9a33d" | ||
dependencies = [ | ||
"windows-targets 0.52.4", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This section duplicates the section above, shouldn't the previous be removed?
The same applies for all the windows-*
sections from here and below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IDK. I just invoked cargo update
and presented the outcome here. How would I produce a different outcome?
Maybe delete the .lock
file first? Do we expect that this will yield a different one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to be a known issue for cargo update
: rust-lang/cargo#7285
Maybe just remove them manually and keep the newer versions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've adjusted the Cargo.lock file manually with 030ca1c. Apparently, the job still succeeds, so we can pretend the changes are sound?
This is inside:
Specifically, all Windows-related packages referring to version 0.48.x have been removed manually.
Now using:
- windows-sys 0.52.0
- windows-targets 0.52.4
3cf09fa
to
42009f3
Compare
docker run --rm -it --volume=$(PWD):/src rust bash cd /src cargo update
Specifically, all Windows-related packages referring to version 0.48.x have been removed manually. Now using: - windows-sys 0.52.0 - windows-targets 0.52.4
42009f3
to
030ca1c
Compare
About
Update dependencies in
tests/client_tests/rust/Cargo.lock
.Background
Two admonitions by Dependabot.
https://github.com/crate/crate-qa/security/dependabot
Details