Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI pipeline to test and release the connector. #17

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

surister
Copy link
Collaborator

@surister surister commented Feb 19, 2025

Summary of the changes / Why this is an improvement

The pipeline does:

  • validate the connector on pull requests
  • validate + build/upload on release

The installation method of connector-packager is done this way because the connector packager needs files that are not shipped in the package, we could probably just install with pip+subdirectory and git clone with sparse the needed files but the
most straight forwarded way and the documented/recommended by Tableau's team is to just clone the project.

You can see that it works in my fork: https://github.com/surister/cratedb-tableau-connector/actions/runs/13413695451/job/37469312400

@surister surister force-pushed the feature/ci_testing branch 3 times, most recently from 6fa17b7 to 75d9292 Compare February 19, 2025 14:05
@surister surister marked this pull request as ready for review February 19, 2025 14:06
@surister surister requested review from amotl and kneth February 19, 2025 14:06
Copy link
Member

@amotl amotl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

@surister surister merged commit 220bc22 into crate:main Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants