cfr: Add support to directly export to an archive file #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #153 +/- ##
===========================================
- Coverage 80.59% 68.44% -12.15%
===========================================
Files 68 68
Lines 2705 2732 +27
===========================================
- Hits 2180 1870 -310
- Misses 525 862 +337
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
seut
force-pushed
the
s/wtf-archive-output
branch
from
08a06d4
to
ecea4c9
Compare
amotl
requested changes
Jun 1, 2024
There was a problem hiding this comment.
Thank you so much for contributing to the last mile to complete this feature in its first iteration. I've added a few suggestions, and extensive thoughts and rationales why we would like to keep the previous interface as outlined on the CFR documentation page.
seut
force-pushed
the
s/wtf-archive-output
branch
from
5496394
to
958dd70
Compare
amotl
reviewed
Jun 4, 2024
4 tasks
amotl
force-pushed
the
cratedb-wtf
branch
10 times, most recently
from
3de21e2
to
3ce81ec
Compare
seut
force-pushed
the
s/wtf-archive-output
branch
2 times, most recently
from
27b9df8
to
6847658
Compare
seut
changed the title
This was referenced Jun 12, 2024
amotl
force-pushed
the
cratedb-wtf
branch
3 times, most recently
from
ef5438b
to
5a9ef0e
Compare
seut
force-pushed
the
s/wtf-archive-output
branch
from
6847658
to
01960de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some CFR improvements:
tgzfile