Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: This and that #32

Merged
merged 4 commits into from
Jul 10, 2023
Merged

Chore: This and that #32

merged 4 commits into from
Jul 10, 2023

Conversation

amotl
Copy link
Member

@amotl amotl commented Jul 8, 2023

  • Tests: Stronger linting.
  • Tests: Stronger assertions about number of records in database.
  • CI: Use TC_KEEPALIVE to not tear down Testcontainers.
    I've always used it in my sandbox, but missed to bring it to CI.
    It significantly reduces overall runtime, because the CrateDB container takes a few seconds to boot each time.
  • Update backlog.

@amotl amotl requested a review from hammerhead July 8, 2023 21:59
@amotl amotl force-pushed the amo/this-and-that branch 2 times, most recently from 18f7600 to 616f1dc Compare July 8, 2023 22:25
@amotl amotl marked this pull request as ready for review July 9, 2023 11:07
@amotl amotl force-pushed the amo/this-and-that branch 3 times, most recently from 9338700 to 254fc4e Compare July 9, 2023 21:14
Base automatically changed from amo/improve-examples to main July 10, 2023 12:45
@amotl amotl merged commit 4f5dc82 into main Jul 10, 2023
2 of 3 checks passed
@amotl amotl deleted the amo/this-and-that branch July 10, 2023 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants