Skip to content

Conversation

@amotl
Copy link
Member

@amotl amotl commented Nov 26, 2025

Problem

With minio 7.2.19, released on Nov 24, 2025, the workflow breaks.

TypeError: Minio.__init__() takes 1 positional argument but 2 positional arguments (and 3 keyword-only arguments) were given

References

TypeError: Minio.__init__() takes 1 positional argument
but 2 positional arguments (and 3 keyword-only arguments) were given
@coderabbitai
Copy link

coderabbitai bot commented Nov 26, 2025

Walkthrough

A test dependency version constraint for MinIO is updated in pyproject.toml. The entry "minio<7.2.19" is added with a clarifying comment to accommodate compatibility requirements until a newer testcontainers release becomes available.

Changes

Cohort / File(s) Summary
Test dependency version constraint
pyproject.toml
Added optional-dependencies.test entry pinning MinIO to version <7.2.19 with compatibility clarification comment

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

  • Simple dependency version constraint addition with clarifying comment
  • No logic changes or behavioral modifications

Poem

🐰 A carrot-sized fix hops into place,
MinIO versions now keep proper pace,
Testcontainers await their grand debut,
With <7.2.19, we see it through!
🥕✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: fixing minio dependency issues related to constructor signature changes in the test suite.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check ✅ Passed The pull request description clearly identifies the problem (minio 7.2.19 breaking changes), provides the exact error, and references relevant issues and fixes.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-minio

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@amotl amotl marked this pull request as ready for review November 26, 2025 20:01
@amotl amotl requested review from matriv and seut November 26, 2025 20:07
@amotl amotl merged commit 0059b47 into main Nov 27, 2025
35 checks passed
@amotl amotl deleted the fix-minio branch November 27, 2025 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants