Testing: Generalize KeepaliveContainer
from CrateDBContainer
#78
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
Add generalized
KeepaliveContainer
for efficient use of Testcontainers. It will give all containers the ability to honorTC_KEEPALIVE=true
, i.e. not shutting down the container after running the test suite. This significantly improves cycle speed.Details
This generalization to the Testcontainers infrastructure is needed to bring in two subsequent patches, because both will rely on it.
migr8
program #76influxio
, implementingctk load table influxdb2://...
#77Because both will use this very code to run their test cases, I will not bother to add dedicated test cases for the infrastructure code.