Add example programs, with integration test cases, and documentation about standalone use #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amotl
changed the title
amotl
changed the title
amotl
changed the title
amotl
commented
Sep 10, 2023
Comment on lines
+50
to
+64
| def table_exists(table_name: str, schema_name: str = "doc") -> bool: | ||
| """ | ||
| Check if database table exists. | ||
| """ | ||
| conn = connect_database() | ||
| cursor = conn.cursor() | ||
| sql = ( | ||
| f"SELECT table_name FROM information_schema.tables " # noqa: S608 | ||
| f"WHERE table_name = '{table_name}' AND table_schema = '{schema_name}'" | ||
| ) | ||
| cursor.execute(sql) | ||
| rowcount = cursor.rowcount | ||
| cursor.close() | ||
| conn.close() | ||
| return rowcount > 0 |
There was a problem hiding this comment.
@seut: Regarding your remark at crate/cratedb-examples#84 (comment), I am not completely convinced that I like this alternative for each and every occasion.
While I see it is a cleaner approach from the implementation perspective, it falls short on usability, because a generic table_exists function would need to obtain the schema parameter separately, like outlined here.
Sometimes, you just do not have it, because the schema name is opaquely embedded within the database connection string.
There was a problem hiding this comment.
@amotl What about using table_schema = CURRENT_SCHEMA?
There was a problem hiding this comment.
It worked well, see #26. Thanks.
hammerhead
approved these changes
Sep 12, 2023
- Refactor and improve test infrastructure - Improve README about standalone usage
This was referenced Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
This patch brings in two example programs originally contributed by @andnig and added to crate/cratedb-examples#84, into the
examplesfolder here instead.In this way, by adding them to the test suite, we can assure they do not stop working. Through additional assistance by Dependabot, this yields reasonable efficiency to keep the repository up to date with upstream developments, and at the same time, makes sure the corresponding example programs get updated along the lines.
Details