Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifying functionality for rocksdb.purge to use abstract method #82

Merged
merged 1 commit into from
Jan 17, 2023

Conversation

michaeldinzinger
Copy link
Contributor

Analogously to PR #81 and issue #74 for the case of ignite.purge, the code for cleaning the storage directory for the flag rocksdb.purge is updated, so that it also uses the new abstract method createOrCleanDirectory()

Signed-off-by: Michael Dinzinger michael.dinzinger@uni-passau.de

Thanks for contributing to URL Frontier, your efforts are appreciated!

Developer Certificate of Origin

By contributing to URL Frontier, you accept and agree to the following terms and conditions (the Developer Certificate of Origin) for your present and future contributions submitted to URL Frontier.
Please refer to the Developer Certificate of Origin section in CONTRIBUTING.md for details.

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Before opening a PR, please check that:

  • You've squashed your commits into a single one
  • You've described what the PR does or at least point to a related issue
  • You've signed-ff your commits with 'git commit -s'

Thanks!

Signed-off-by: Michael Dinzinger <michael.dinzinger@uni-passau.de>
@jnioche jnioche added the enhancement New feature or request label Jan 17, 2023
@jnioche jnioche added this to the 2.3 milestone Jan 17, 2023
@jnioche jnioche merged commit bc3584e into crawler-commons:master Jan 17, 2023
@jnioche
Copy link
Collaborator

jnioche commented Jan 17, 2023

thanks @michaeldinzinger

@michaeldinzinger michaeldinzinger deleted the devRocksDBPurge branch January 18, 2023 18:20
@jnioche jnioche modified the milestones: 2.3, 2.4.0 Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants