Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NTFY integration, receiving markdown but web app does not transform it #1024

Closed
3 tasks done
stecydube opened this issue Nov 7, 2023 · 2 comments · Fixed by #1025
Closed
3 tasks done

NTFY integration, receiving markdown but web app does not transform it #1024

stecydube opened this issue Nov 7, 2023 · 2 comments · Fixed by #1025

Comments

@stecydube
Copy link
Contributor

Support guidelines

I've found a bug and checked that ...

  • ... the documentation does not mention anything about my problem
  • ... there are no open or closed issues that are related to my problem

Description

Receiving notification on self-hosted in markdown format but it does not get transformed.

Expected behaviour

Given this received notification message:

Docker tag [**docker.io/qmcgaw/gluetun:latest**](github.com/qdm12/gluetun) which you subscribed to through docker provider is available on docker.io registry (triggered by d0c1e3926c61 host).

I should see it in the correct format in the ntfy web app

Docker tag docker.io/qmcgaw/gluetun:latest which you subscribed to through docker provider is available on docker.io registry (triggered by d0c1e3926c61 host).

I think the publish request is missing the Markdown=true parameter.

See https://docs.ntfy.sh/publish/#markdown-formatting

Actual behaviour

I see all the markdown markup. It seems it is not picked up correctly by ntfy.

Steps to reproduce

  1. Have DIUN set up for NTFY notification
  2. Have DIUN detect a new container image so that it sends the notification
  3. Look at the received notification on the NTFY web app

Diun version

4.26.0

Docker info

Client:
 Context:    default
 Debug Mode: false

Server:
 Containers: 17
  Running: 17
  Paused: 0
  Stopped: 0
 Images: 18
 Server Version: 20.10.23
 Storage Driver: btrfs
  Build Version: Btrfs v4.0
  Library Version: 101
 Logging Driver: db
 Cgroup Driver: cgroupfs
 Cgroup Version: 1
 Plugins:
  Volume: local
  Network: bridge host ipvlan macvlan null overlay
  Log: awslogs db fluentd gcplogs gelf journald json-file local logentries splunk syslog
 Swarm: inactive
 Runtimes: io.containerd.runc.v2 io.containerd.runtime.v1.linux runc
 Default Runtime: runc
 Init Binary: docker-init
 containerd version: b23a389d8c181697302d163356e97dec04eb8d88
 runc version: 5af893d
 init version: ed96d00
 Security Options:
  apparmor
 Kernel Version: 3.10.108
 Operating System: DiskStation

 OSType: linux
 Architecture: x86_64
 CPUs: 4
 Total Memory: 7.718GiB
 Name: XXXXXXXXXXXXXXXXXX
 ID: XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX
 Docker Root Dir: /volume1/@docker
 Debug Mode: false
 Registry: https://index.docker.io/v1/
 Labels:
 Experimental: false
 Insecure Registries:
  127.0.0.0/8
 Live Restore Enabled: false

WARNING: No kernel memory TCP limit support
WARNING: No cpu cfs quota support
WARNING: No cpu cfs period support
WARNING: No blkio throttle.read_bps_device support
WARNING: No blkio throttle.write_bps_device support
WARNING: No blkio throttle.read_iops_device support
WARNING: No blkio throttle.write_iops_device support

Docker Compose config

No response

Logs

None

Additional info

No response

@stecydube
Copy link
Contributor Author

I've created a pull request to fix this:

#1025

Although I do not know GO and don't know how to test this, this should fix it hopefully

@stecydube
Copy link
Contributor Author

Used GitHub codespaces and followed the contributing doc.
I was able to test it 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant