Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NTFY markdown #1025

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Fix NTFY markdown #1025

merged 1 commit into from
Dec 5, 2023

Conversation

stecydube
Copy link
Contributor

@stecydube stecydube commented Nov 7, 2023 •
edited by crazy-max
Loading

fixes #1024

Ensure the notification payload includes the "markdown" field set to true.

@stecydube stecydube mentioned this pull request Nov 7, 2023
Closed
3 tasks
IamTheFij
IamTheFij suggested changes Nov 8, 2023
View reviewed changes
internal/notif/ntfy/client.go Outdated Show resolved Hide resolved
@stecydube
Copy link
Contributor Author

Is there anything missing to get this PR completed?
@crazy-max @IamTheFij

ViViDboarder
ViViDboarder approved these changes Dec 4, 2023
View reviewed changes
Copy link

@ViViDboarder ViViDboarder left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but @crazy-max is the maintainer.

crazy-max
crazy-max requested changes Dec 4, 2023
View reviewed changes
Copy link
Owner

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you squash your commits please?

Otherwise LGTM, thanks

@stecydube
Fix NTFY markdown
d999959 
Ensure the notification payload includes the "markdown" field set to true.
@stecydube
Copy link
Contributor Author

Can you squash your commits please?

Otherwise LGTM, thanks

@crazy-max Done

crazy-max
crazy-max approved these changes Dec 4, 2023
View reviewed changes
Copy link
Owner

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@crazy-max crazy-max merged commit 131beb4 into crazy-max:master Dec 5, 2023
32 checks passed
@stecydube stecydube deleted the patch-1 branch December 5, 2023 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IamTheFij IamTheFij IamTheFij approved these changes

@crazy-max crazy-max crazy-max approved these changes

@ViViDboarder ViViDboarder ViViDboarder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NTFY integration, receiving markdown but web app does not transform it
4 participants
@stecydube @ViViDboarder @crazy-max @IamTheFij