-
-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support signal rest api notifications #650
Conversation
134c1be
to
6e0a6d9
Compare
Any objections? |
If I understand correctly, this notification will be sent to the https://github.com/bbernhard/signal-cli-rest-api service and then be sent to Signal itself? If so I would be prefer to not use this intermediate service and directly send the notification to Signal. Also looking at signal-cli-rest-api it looks like you can directly use the |
This rest API is just a small wrapper around https://github.com/AsamK/signal-cli which is a binary to talk with the Signal API, which has all the stuff implemented. |
I see that the official https://github.com/signalapp/libsignal doesn't have the Go implementation/binding unfortunately. I found some custom implementations https://libs.garden/go/search?q=libsignal but looks not well maintained. Maybe the C part of the Swift bindings could be used from Go as well but would need to have it on another repo first.
Ah indeed we can't customize the payload atm.
Yes feel free to open another PR to be able to send a custom payload for the webhook notifier and we can take a look here if it fits your needs or requires a dedicated notifier. |
I already tried to modify the custom webhook, but since I am not very familar with golang, I struggled what the best way is to support any abritary json data. Therefore I went with the native signal implementation, which was much easier. But if you can give me any pointer how to do it, I can submit a PR for the webhook, too. |
The signal rest-api is quite a famous solution to use for Signal, e.g. https://github.com/louislam/uptime-kuma/blob/master/src/components/notifications/Signal.vue and https://www.home-assistant.io/integrations/signal_messenger/ both recommend to use it. |
I will take a look and open a PR that's fine.
I see, then I'm ok with this notifier if you can add some docs. I will review after that. |
6223244
to
d382e47
Compare
d382e47
to
7e8227a
Compare
I added docs. Feel free to review and leave comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks!
Hi,
I created a notification for https://github.com/bbernhard/signal-cli-rest-api
If you are interested in this notification I can finish the missing things like documentation, enhance code, etc...?