Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the issues URL #697

Merged
merged 1 commit into from
Oct 7, 2022
Merged

Correct the issues URL #697

merged 1 commit into from
Oct 7, 2022

Conversation

DougEdey
Copy link
Contributor

@DougEdey DougEdey commented Oct 7, 2022

The repo_url does not contain a trailing slash, so the link is a 404, and with the q= query in the URL it searches all Issues & PRs which is not what I think is wanted.

Current URL: https://github.com/crazy-max/diunissues?utf8=%E2%9C%93&q=
New URL: https://github.com/crazy-max/diun/issues?utf8=%E2%9C%93

The repo_url does not contain a trailing slash, so the link is a 404, and with the `q=` query in the URL it searches all Issues & PRs which is not what I think is wanted.
Copy link
Owner

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@crazy-max crazy-max merged commit 2db20dd into crazy-max:master Oct 7, 2022
@DougEdey DougEdey deleted the patch-1 branch October 8, 2022 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants