Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs for defaults configuration #982

Merged
merged 4 commits into from
Sep 23, 2023
Merged

Docs for defaults configuration #982

merged 4 commits into from
Sep 23, 2023

Conversation

crazy-max
Copy link
Owner

follow-up #981
carry and closes #977

@IamTheFij Carry your changes from #977 and refactor after #981 as I have moved imageDefaults from watch to defaults in the configuration.

@IamTheFij
Copy link
Contributor

Looks good to me! I'm excited to have this merged. The ability to have new semver tags to notify as a global setting is going to be very useful.

Copy link
Contributor

@IamTheFij IamTheFij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The one comment I have is a suggestion to include an example of configuring for global semver tags. I think that's not an uncommon use case that this enables and it may be helpful to show people how it could be done. I could add an example in another PR though. Possibly in some other section of documentation like "examples".

@crazy-max
Copy link
Owner Author

The one comment I have is a suggestion to include an example of configuring for global semver tags. I think that's not an uncommon use case that this enables and it may be helpful to show people how it could be done. I could add an example in another PR though. Possibly in some other section of documentation like "examples".

Yes we could have an example in "User guides" section for this matter but not in reference docs.

Feel free to open a PR ofc and thanks again for your contribution!

@crazy-max crazy-max merged commit 8249e5c into master Sep 23, 2023
32 checks passed
@crazy-max crazy-max deleted the default-docs branch September 23, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants