Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure xml-rpc correctly #198

Merged
merged 1 commit into from
Jan 1, 2023
Merged

Configure xml-rpc correctly #198

merged 1 commit into from
Jan 1, 2023

Conversation

stickz
Copy link
Contributor

@stickz stickz commented Dec 31, 2022

xmlrpc-c is not configured properly. It will cause a very significant performance regression, if the wininet and libwww clients are not disabled. We want xmlrpc-c to use curl because it's razor fast and stable. These changes require testing before being merged. I don't have time to test it. The change value is of high importance, which is why I rushed the pull request.

`xmlrpc-c` is not configured properly. It will cause a very significant performance regression, if the `wininet` and `libwww` clients are not disabled. We want `xmlrpc-c` to use `curl` because it's razor fast and stable. These changes require testing before being merged. I don't have time to test it. The change value is of high importance.
@stickz stickz requested a review from crazy-max as a code owner December 31, 2022 18:53
Copy link
Owner

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@crazy-max crazy-max merged commit 8a78324 into crazy-max:master Jan 1, 2023
@stickz stickz deleted the patch-1 branch January 2, 2023 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants