Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanitize the color field to allow using hex codes #207

Merged
merged 2 commits into from
Feb 6, 2024
Merged

Sanitize the color field to allow using hex codes #207

merged 2 commits into from
Feb 6, 2024

Conversation

pjpires
Copy link
Contributor

@pjpires pjpires commented Feb 6, 2024

Found myself struggling with the color field, as I was unfamiliar with the underlying GitHub API.

This PR fixes #153 and adds a test scenario for hex code colors.
Replaces and closes #172.

src/labeler.ts Outdated Show resolved Hide resolved
Copy link
Owner

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but can you:

Thanks!

@pjpires
Copy link
Contributor Author

pjpires commented Feb 6, 2024

Looks good but can you:

* squash your commits

* run `docker buildx bake pre-checkin` per [`master`/.github/CONTRIBUTING.md#submitting-a-pull-request](https://github.com/crazy-max/ghaction-github-labeler/blob/master/.github/CONTRIBUTING.md?rgh-link-date=2024-02-06T14%3A26%3A35Z#submitting-a-pull-request)

* push commit with generated files changes similar to [#187 (commits)](https://github.com/crazy-max/ghaction-github-labeler/pull/187/commits) with commit message `update generated content`

Thanks!

Sorry, I've read the contributing instructions but I didn't get that you meant the result of running docker buildx bake pre-checkin to be a separate commit. Can you please double check if everything looks good now? Thanks!

Copy link
Owner

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@crazy-max crazy-max merged commit 6d1e91b into crazy-max:master Feb 6, 2024
6 checks passed
@pjpires pjpires deleted the feature/allow-hex-color-codes branch February 6, 2024 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow hash in color codes
2 participants