Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POSIX-compliant inputs names #109

Merged
merged 1 commit into from
Sep 4, 2021
Merged

POSIX-compliant inputs names #109

merged 1 commit into from
Sep 4, 2021

Conversation

crazy-max
Copy link
Owner

No description provided.

@codecov
Copy link

codecov bot commented Sep 4, 2021

Codecov Report

Merging #109 (e98839d) into master (e8a90f2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #109   +/-   ##
=======================================
  Coverage   81.48%   81.48%           
=======================================
  Files           3        3           
  Lines         108      108           
  Branches       24       24           
=======================================
  Hits           88       88           
  Misses         11       11           
  Partials        9        9           
Impacted Files Coverage Δ
src/context.ts 83.33% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8a90f2...e98839d. Read the comment docs.

@crazy-max crazy-max merged commit 3a2a627 into master Sep 4, 2021
@crazy-max crazy-max deleted the posix-inputs branch September 4, 2021 23:12
@OJFord
Copy link

OJFord commented Oct 20, 2021

POSIX cares about YAML keys?

This is quite non-standard in my experience, and a bit confusing next to (most) other actions with 'kebab-case' args.

@crazy-max
Copy link
Owner Author

@OJFord Yes in some cases someone can use INPUT_* in an underlying action so INPUT_GIT_CONFIG_GLOBAL is valid but not INPUT_GIT-CONFIG-GLOBAL.

@OJFord
Copy link

OJFord commented Oct 20, 2021

Oof I see, yes, that's unfortunate.

https://docs.github.com/en/actions/creating-actions/metadata-syntax-for-github-actions#example

Thanks for the reply.

@peter-evans
Copy link

This just caught me out when upgrading and I don't really understand what the concern is here. This is non-standard. GitHub's official actions use kebab-case input names, like checkout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants