-
-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GH action to build library artifacts #188
Conversation
This is a good idea, but we may not do it at the moment. Because each compiled extension only includes the libraries it must depend on, ignoring optional dependencies. I know we could include all suggested libs, but it will make it impossible to compile without suggesting libs, we lost flexibility. Additionally there are some Also, the current build system is not perfect. Some libraries or extensions using the C++ language can only be compiled under Alpine. At least now, we cannot directly use the |
I think we need to start somewhere ;) |
|
2bdfcff
to
0476ec3
Compare
419fe4b
to
71b64e6
Compare
Reworked the action & it now uses pre-generated binary 😮💨 Tested on my repo: https://github.com/stloyd/static-php-build/actions/runs/6208292912 (workflow is a little bit different cause it needed to access external repository) |
I have the following questions to figure out. For Actions, what is the scope of its cache? Assuming others use Because there are too many libraries now with optional dependencies. Optional dependencies for compilation are always dynamic and can be combined in too many ways. Also, I think it would be better to set up a separate
|
Generated artifacts can be downloaded & re-used instead of built locally.
Example of
curl
library pre-build for osx: https://github.com/stloyd/static-php-build/actions/runs/6198320093Extracted locally to
buildroot
dir: