-
-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add command to dump required PHP extensions based on vendor/composer/… #599
base: main
Are you sure you want to change the base?
Conversation
…installed.json, composer.lock, composer.json (in this order)
|
The most accurate result is given, if you have all 3 files exist. Maybe i can add an error if composer install was not run in before (so installed.json is not present) or at least composer.lock must be present.
I've just created the logic to get all extensions from all possible files. Gimme some more informations on what your goal is and i will change it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mainly separated files to parse and add some options, and if you think there's anything that needs improvement, feel free to suggest it.
Looks fine and works for me. Maybe we can add |
It is possible to implement internal calls, but I am not very good at parameter naming and design, especially in mixed parameter situations (sometimes I need to merge the list of extensions exported in the project and the list of extensions specified via the command line). |
We also need to add back composer.json to the list of parsed files. Why? Because if i have custom extension requirements in my project, they will only be found in composer.json, not reflected in composer.lock |
@CyberLine It can be found in {
"platform": {
"php": ">= 8.1",
"ext-mbstring": "*",
"ext-zlib": "*"
}
} |
…installed.json, composer.lock, composer.json (in this order)
What does this PR do?
This fixes #338