Download CRC installer binary on runtime #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
gbraad
reviewed
Mar 13, 2023
| const progressStr = /* progress.transferred + ' of ' + progress.total + ' ' + */Math.round(progress.percent * 100) + '%'; | ||
| if(lastProgressStr !== progressStr) { | ||
| //TODO: show progress on UI! | ||
| this.statusBarItem.text = 'Downloading: ' + progressStr; |
There was a problem hiding this comment.
This is allowed ;-), but the rest of the API is restrictive...
gbraad
reviewed
Mar 13, 2023
| try { | ||
| if (fs.existsSync(pkgPath)) { | ||
| if (await isFileExists(pkgPath)) { |
There was a problem hiding this comment.
is this related to the main ui async issue you mentioned?
There was a problem hiding this comment.
yes, I made a lot of sync code clean up, ensuring that we don’t use any synchronous code/IO operation.
gbraad
approved these changes
Mar 13, 2023
|
Not expecting it here, but is it possible to switch to silent (background) installer in the future? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The move CRC extension to separate repo force us to downloading CRC installation binary in runtime, after user click install button.
Demo Windows:
crc-download-install.mp4
Demo MacOS:
Screen.Recording.2023-03-13.at.12.44.11.mp4