Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add preset info to telemetry:crc.start #161

Merged
merged 1 commit into from
Jul 7, 2023

Conversation

gbraad
Copy link
Contributor

@gbraad gbraad commented Jun 28, 2023

Fixes #155

@gbraad
Copy link
Contributor Author

gbraad commented Jun 28, 2023

Seriously, I hate the linter:

-      preset: crcStatus.status.Preset
+      preset: crcStatus.status.Preset,

WHY?!?!?!?

@gbraad gbraad force-pushed the telemetry-start-params branch from 000a084 to bd16a3c Compare June 28, 2023 07:19
@gbraad
Copy link
Contributor Author

gbraad commented Jun 28, 2023

Oh no, wait... running:

$ npx prettier -w src/*.ts

results in:

-  telemetryLogger.logUsage('crc.start',
-    {
-      preset: crcStatus.status.Preset,
-    });
+  telemetryLogger.logUsage('crc.start', {
+    preset: crcStatus.status.Preset,
+  });

Which means npm run lint:fix was even wrong???

@gbraad gbraad force-pushed the telemetry-start-params branch from bd16a3c to a87f128 Compare June 28, 2023 07:37
@gbraad
Copy link
Contributor Author

gbraad commented Jul 7, 2023

@crc-org/crc-extension-team @jeffmaury @dgolovin Hope anyone can take a look.

Copy link
Collaborator

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gbraad gbraad merged commit 891ff0c into crc-org:main Jul 7, 2023
@gbraad gbraad deleted the telemetry-start-params branch July 7, 2023 13:32
@gbraad gbraad restored the telemetry-start-params branch July 7, 2023 13:40
@gbraad gbraad deleted the telemetry-start-params branch July 7, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Telemetry should include preset
3 participants