Add an oci image to act as a cache builder for a multistage building strategy #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrianriobo
changed the title
benoitf
reviewed
May 23, 2024
.github/workflows/build-builder.yaml
Outdated
|
|
||
| jobs: | ||
| build-and-push-image: | ||
| runs-on: ubuntu-latest |
There was a problem hiding this comment.
you should specify the version and not latest as it may shift and provides unexpected behaviour
adrianriobo
force-pushed
the
fix-213-builder
branch
from
4f14152
to
f7d4b96
Compare
benoitf
approved these changes
May 29, 2024
| @@ -0,0 +1,35 @@ | |||
| name: build-builder | |||
There was a problem hiding this comment.
👍 btw should I update the dates to 2024?
benoitf
reviewed
May 29, 2024
.github/workflows/build-builder.yaml
Outdated
|
|
||
| jobs: | ||
| build-and-push-image: | ||
| runs-on: ubuntu-22.04 |
There was a problem hiding this comment.
oh interesting I trust on PD repo so I pick the version from there 😂 let me check and update from official gh doc
There was a problem hiding this comment.
I think we're in the process of updating it
…tegy This image will act as a cache for the node modules requried to build the extension Signed-off-by: Adrian Riobo Lorenzo <ariobolo@redhat.com>
adrianriobo
force-pushed
the
fix-213-builder
branch
from
f7d4b96
to
dca2702
Compare
benoitf
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will add the Containerfile require to build the cache builder which will be used as part of the multistage building strategy.