Enhance configuration sync and validation #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
gbraad
reviewed
Apr 6, 2023
| } | ||
| } | ||
|
|
||
| export function getDefaultMemory(preset: Preset): number { |
There was a problem hiding this comment.
Nothing about disksize?
Did @praveenkumar keep that identical?
gbraad
reviewed
Apr 6, 2023
| 'OpenShift-Local.pullsecretfile': ['pull-secret-file', 'Pullsecret file path'], | ||
| 'OpenShift-Local.cpus': { name: 'cpus', label: 'CPUS', needDialog: true, validation: validateCpus }, | ||
| 'OpenShift-Local.memory': { name: 'memory', label: 'Memory', needDialog: true, validation: validateRam }, | ||
| 'OpenShift-Local.preset': { name: 'preset', label: 'Preset', needDialog: true, requiresRecreate: true }, |
gbraad
reviewed
Apr 6, 2023
| 'OpenShift-Local.preset': ['preset', 'Preset'], | ||
| 'OpenShift-Local.disksize': ['disk-size', 'Disk Size'], | ||
| 'OpenShift-Local.pullsecretfile': ['pull-secret-file', 'Pullsecret file path'], | ||
| 'OpenShift-Local.cpus': { name: 'cpus', label: 'CPUS', needDialog: true, validation: validateCpus }, |
gbraad
reviewed
Apr 6, 2023
| 'OpenShift-Local.disksize': ['disk-size', 'Disk Size'], | ||
| 'OpenShift-Local.pullsecretfile': ['pull-secret-file', 'Pullsecret file path'], | ||
| 'OpenShift-Local.cpus': { name: 'cpus', label: 'CPUS', needDialog: true, validation: validateCpus }, | ||
| 'OpenShift-Local.memory': { name: 'memory', label: 'Memory', needDialog: true, validation: validateRam }, |
gbraad
reviewed
Apr 6, 2023
| syncProxy(context); | ||
| } | ||
|
|
||
| async function syncProxy(context: extensionApi.ExtensionContext): Promise<void> { |
There was a problem hiding this comment.
Also only on restart if not mistaken.
gbraad
reviewed
Apr 6, 2023
| return `Requires Memory in MiB >= ${getDefaultMemory(crcStatus.status.Preset as Preset)}`; | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
async function handleRestart(): Promise<void> {
...
buttons.unshift('Restart now');
buttons.unshift('Restart later');
...
}
gbraad
approved these changes
Apr 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR remove default and minimum values from crc-extension configuration.
Add validation of configuration property based on current preset.
Also it inform and assist user recreate instance when preset changed.
And PR add proxy setting sync, but in case of proxy settings we copy setting from podman-desktop to crc.
Resolves #32
Demo:
Screen.Recording.2023-04-04.at.15.14.40.1.mov