chore(tests): add check for settings/preferences assets #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danivilla9
force-pushed
the
extend-installation-handling-test-case-399
branch
2 times, most recently
from
ccec386
to
73cd962
Compare
odockal
requested changes
Nov 11, 2024
Signed-off-by: Daniel Villanueva <davillan@redhat.com> chore(tests): putting test.fail() properly Signed-off-by: Daniel Villanueva <davillan@redhat.com> chore(tests): fixes on the assertions Signed-off-by: Daniel Villanueva <davillan@redhat.com> chore(tests): missing awaits Signed-off-by: Daniel Villanueva <davillan@redhat.com> chore(tests): check tab existence differently Signed-off-by: Daniel Villanueva <davillan@redhat.com> chore(tests): check inside settings/preferences Signed-off-by: Daniel Villanueva <davillan@redhat.com> chore(tests): missing not fixed Signed-off-by: Daniel Villanueva <davillan@redhat.com> chore(tests): ondrej's feedback Signed-off-by: Daniel Villanueva <davillan@redhat.com> chore(tests): removed redundant fail test case Signed-off-by: Daniel Villanueva <davillan@redhat.com> chore(tests): fixing test not failing? Signed-off-by: Daniel Villanueva <davillan@redhat.com> chore(tests): another test Signed-off-by: Daniel Villanueva <davillan@redhat.com> chore(tests): removed the wrong step... Signed-off-by: Daniel Villanueva <davillan@redhat.com> chore(tests): fixed linting issue Signed-off-by: Daniel Villanueva <davillan@redhat.com>
danivilla9
force-pushed
the
extend-installation-handling-test-case-399
branch
from
8fbe577
to
f2c47b0
Compare
odockal
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #399