Mac/Windows: Check if daemon able to serve after it starts

This PR add time limit (15 sec) to make sure daemon able to serve
the requests after it is start because sometimes just after start
it takes time to serve.

fixes: #3148

pkg/crc/preflight/preflight_checks_darwin.go

@@ -11,7 +11,6 @@ import (
 
 	"github.com/code-ready/crc/pkg/crc/cache"
 	"github.com/code-ready/crc/pkg/crc/constants"
-	"github.com/code-ready/crc/pkg/crc/daemonclient"
 	"github.com/code-ready/crc/pkg/crc/logging"
 	"github.com/code-ready/crc/pkg/crc/version"
 	crcos "github.com/code-ready/crc/pkg/os"
@@ -191,13 +190,6 @@ func checkIfDaemonPlistFileExists() error {
 	return nil
 }
 
-func daemonRunning() bool {
-	if _, err := daemonclient.GetVersionFromDaemonAPI(); err != nil {
-		return false
-	}
-	return true
-}
-
 func fixDaemonPlistFileExists() error {
 	if err := olderDaemonVersionRunning(); err != nil {
 		if err := killDaemonProcess(); err != nil {
@@ -232,5 +224,5 @@ func fixPlistFileExists(agentConfig launchd.AgentConfig) error {
 		logging.Debugf("failed to restart launchd agent '%s': %v", agentConfig.Label, err.Error())
 		return err
 	}
-	return nil
+	return waitForDaemonRunning()
 }

pkg/crc/preflight/preflight_checks_nonlinux.go

@@ -4,10 +4,14 @@
 package preflight
 
 import (
+	"context"
+	"fmt"
 	"runtime"
 	"strings"
+	"time"
 
 	"github.com/code-ready/crc/pkg/crc/daemonclient"
+	crcerrors "github.com/code-ready/crc/pkg/crc/errors"
 	"github.com/code-ready/crc/pkg/crc/logging"
 	"github.com/shirou/gopsutil/v3/process"
 )
@@ -70,3 +74,19 @@ func olderDaemonVersionRunning() error {
 	}
 	return daemonclient.CheckIfOlderVersion(v)
 }
+
+func daemonRunning() bool {
+	if _, err := daemonclient.GetVersionFromDaemonAPI(); err != nil {
+		return false
+	}
+	return true
+}
+
+func waitForDaemonRunning() error {
+	return crcerrors.Retry(context.Background(), 15*time.Second, func() error {
+		if !daemonRunning() {
+			return &crcerrors.RetriableError{Err: fmt.Errorf("daemon is not running yet")}
+		}
+		return nil
+	}, 2*time.Second)
+}

pkg/crc/preflight/preflight_daemon_task_check_windows.go

@@ -156,7 +156,7 @@ func fixDaemonTaskRunning() error {
 		logging.Debugf("unable to run the %s task: %v : %s", constants.DaemonTaskName, err, stderr)
 		return err
 	}
-	return nil
+	return waitForDaemonRunning()
 }
 
 func checkIfOlderTask() error {