Skip to content

Commit

Permalink
spec: disable stripping of binaries
Browse files Browse the repository at this point in the history
The stripping done by rpmbuild interferes with the way crc embeds
binaries in its executable. This commit disables it.

Arguably, the binary installed in /usr/bin should *not* embed anything,
and crc should use yum-installed crc-admin-helper and
crc-driver-libvirt, but that work hasn't been done yet.
  • Loading branch information
cfergeau authored and praveenkumar committed Feb 23, 2022
1 parent 069f33c commit 6019341
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions packaging/rpm/crc.spec.in
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ Version: __VERSION__
# debuginfo is not supported on RHEL with Go packages
%global debug_package %{nil}
%global _enable_debug_package 0
# disable stripping of binaries/... as this interferes with the embedding used by crc
%global __os_install_post /usr/lib/rpm/brp-compress %{nil}

%global common_description %{expand:
CodeReady Container's executable}
Expand Down

0 comments on commit 6019341

Please sign in to comment.