Skip to content

Commit

Permalink
update golang to 1.19
Browse files Browse the repository at this point in the history
This will be needed for newer golangci-lint versions
With the release of golang 1.20, only go 1.19 and 1.20 are still
supported.
The macOS root certificate bug that had been holding back this upgrade
is fixed in golang 1.19.5
  • Loading branch information
cfergeau authored and openshift-merge-robot committed Feb 22, 2023
1 parent 6149936 commit 8ec3b43
Show file tree
Hide file tree
Showing 13 changed files with 11 additions and 749 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/macos-installer.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
- macOS-latest
- macOS-11
go:
- 1.17
- 1.19
steps:
# Enable tmate debugging of manually-triggered workflows if the input option was provided
- name: Setup tmate session
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/make-check-win.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
- windows-2019
- windows-2022
go:
- 1.17
- 1.19
steps:
- name: Downgrade mingw to workaround https://github.com/golang/go/issues/46099
run: choco install mingw --version 10.2.0 --allow-downgrade
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/make-check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
- ubuntu-latest
- ubuntu-20.04
go:
- 1.17
- 1.19
steps:
- name: Check out repository code
uses: actions/checkout@v3
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/make-rpm.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
os:
- ubuntu-latest
go:
- 1.17
- 1.19
steps:
- name: Check out repository code
uses: actions/checkout@v3
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/windows-chocolatey.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
os:
- windows-2022
go:
- 1.17
- 1.19
steps:
- name: Check out repository code
uses: actions/checkout@v3
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/windows-installer.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
- windows-2019
- windows-2022
go:
- 1.17
- 1.19
steps:
- name: Check out repository code
uses: actions/checkout@v3
Expand Down
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/crc-org/crc

go 1.17
go 1.19

require (
github.com/AlecAivazis/survey/v2 v2.3.4
Expand Down
396 changes: 0 additions & 396 deletions go.sum

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion images/build-e2e/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM registry.access.redhat.com/ubi8/go-toolset:1.17 as builder
FROM registry.access.redhat.com/ubi8/go-toolset:1.19 as builder

USER root
WORKDIR /workspace
Expand Down
2 changes: 1 addition & 1 deletion images/build-integration/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM registry.access.redhat.com/ubi8/go-toolset:1.17 as builder
FROM registry.access.redhat.com/ubi8/go-toolset:1.19 as builder

USER root
WORKDIR /workspace
Expand Down
2 changes: 1 addition & 1 deletion images/openshift-ci/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# This Dockerfile is used by openshift CI
# It builds an image containing crc and nss-wrapper for remote deployments, as well as the google cloud-sdk for nested GCE environments.

FROM registry.ci.openshift.org/openshift/release:golang-1.17 AS builder
FROM registry.ci.openshift.org/openshift/release:golang-1.19 AS builder
WORKDIR /go/src/github.com/crc-org/crc
COPY . .
RUN make release
Expand Down
2 changes: 1 addition & 1 deletion tools/go.mod
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/crc-org/crc/tools

go 1.17
go 1.19

require (
github.com/cfergeau/gomod2rpmdeps v0.0.0-20210223144124-2042c4850ca8
Expand Down
342 changes: 0 additions & 342 deletions tools/go.sum

Large diffs are not rendered by default.

0 comments on commit 8ec3b43

Please sign in to comment.