Skip to content

Commit

Permalink
lint: start: Fix 'unused-parameter' error
Browse files Browse the repository at this point in the history
pkg/crc/machine/start.go:821:27: unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
func configurePodmanProxy(ctx context.Context, sshRunner *crcssh.Runner, proxy *httpproxy.ProxyConfig) (err error) {
                          ^
make: *** [Makefile:265: cross-lint] Error 1
  • Loading branch information
cfergeau authored and praveenkumar committed Aug 4, 2023
1 parent 01c7af2 commit 9c2b5c4
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions pkg/crc/machine/start.go
Original file line number Diff line number Diff line change
Expand Up @@ -472,7 +472,7 @@ func (client *client) Start(ctx context.Context, startConfig types.StartConfig)
// **************************
// END OF PODMAN START CODE
// **************************
if err := configurePodmanProxy(ctx, sshRunner, proxyConfig); err != nil {
if err := configurePodmanProxy(sshRunner, proxyConfig); err != nil {
return nil, errors.Wrap(err, "Failed to configure proxy for podman")
}
if err := dns.AddPodmanHosts(instanceIP); err != nil {
Expand Down Expand Up @@ -818,7 +818,7 @@ func copyKubeconfigFileWithUpdatedUserClientCertAndKey(selfSignedCAKey *rsa.Priv
return updateClientCrtAndKeyToKubeconfig(clientKey, clientCert, srcKubeConfigPath, dstKubeConfigPath)
}

func configurePodmanProxy(ctx context.Context, sshRunner *crcssh.Runner, proxy *httpproxy.ProxyConfig) (err error) {
func configurePodmanProxy(sshRunner *crcssh.Runner, proxy *httpproxy.ProxyConfig) (err error) {
if !proxy.IsEnabled() {
return nil
}
Expand Down

0 comments on commit 9c2b5c4

Please sign in to comment.