Skip to content

Commit

Permalink
preflight: Reword checkM1CPU error message
Browse files Browse the repository at this point in the history
The M1 CPU check is checking for running crc as an emulated x86_64
binary on M1 CPUs. This is not a check which detects M1 CPUs and errors
out regardless of the binary arch. This rewords the error message to
make this clearer.
  • Loading branch information
cfergeau authored and praveenkumar committed May 4, 2022
1 parent d718fa0 commit feeaf9f
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion pkg/crc/preflight/preflight_checks_darwin.go
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ const (
func checkM1CPU() error {
if strings.HasPrefix(cpuid.CPU.BrandName, "VirtualApple") {
logging.Debugf("Running with an emulated x86_64 CPU")
return fmt.Errorf("CRC is unsupported on Apple M1 hardware")
return fmt.Errorf("This version of CRC for AMD64/Intel64 CPUs is unsupported on Apple M1 hardware")
}

return nil
Expand Down
2 changes: 1 addition & 1 deletion pkg/crc/preflight/preflight_darwin.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ func hyperkitPreflightChecks(networkMode network.Mode) []Check {
configKeySuffix: "check-m1-cpu",
checkDescription: "Checking if running emulated on a M1 CPU",
check: checkM1CPU,
fixDescription: "CRC is unsupported on Apple M1 hardware",
fixDescription: "This version of CRC for AMD64/Intel64 CPUs is unsupported on Apple M1 hardware",
flags: NoFix,

labels: labels{Os: Darwin},
Expand Down

0 comments on commit feeaf9f

Please sign in to comment.