Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misleading message after changing preset #2859

Closed
Tracked by #2936
cfergeau opened this issue Nov 30, 2021 · 2 comments · Fixed by #2946
Closed
Tracked by #2936

Misleading message after changing preset #2859

cfergeau opened this issue Nov 30, 2021 · 2 comments · Fixed by #2946
Assignees
@praveenkumar
Labels
preset/podman Issue with podman preset

Comments

@cfergeau
Copy link
Contributor

It currently says:

$ crc config set preset podman
"Changes to configuration property 'preset' are only applied when the CRC instance is created."
"If you already have a running CRC instance, then for this configuration change to take effect, delete the CRC instance with 'crc delete' and start it with 'crc start'."

but if the podman bundle is not available yet, crc setup will be needed.
@cfergeau
Copy link
Contributor Author

Some of the suggestions in #2860 would make this unneeded.

@gbraad gbraad mentioned this issue Jan 11, 2022
Closed
6 tasks
@praveenkumar praveenkumar added the preset/podman Issue with podman preset label Jan 11, 2022
praveenkumar added a commit to praveenkumar/crc that referenced this issue Jan 18, 2022
@praveenkumar
Config: Add callback function to have message about setup in case of …
b0beeb6 
…preset change

fixes: crc-org#2859
@praveenkumar praveenkumar mentioned this issue Jan 18, 2022
Merged
@gbraad gbraad linked a pull request Jan 18, 2022 that will close this issue
Fixes Misc issue for dev branch #2946
Merged
@gbraad gbraad moved this to Ready for review in Project planning Jan 18, 2022
praveenkumar added a commit to praveenkumar/crc that referenced this issue Jan 19, 2022
@praveenkumar
Config: Add callback function to have message about setup in case of …
d64ad6d 
…preset change

fixes: crc-org#2859
praveenkumar added a commit to praveenkumar/crc that referenced this issue Jan 19, 2022
@praveenkumar
Config: Add callback function to have message about setup in case of …
7c6b9a2 
…preset change

fixes: crc-org#2859
praveenkumar added a commit that referenced this issue Jan 20, 2022
@praveenkumar
Config: Add callback function to have message about setup in case of …
92d4cbb 
…preset change

fixes: #2859
@gbraad gbraad changed the title Misleading message after changing preset Onboarding onClose message gets shown after appStart happened Jan 21, 2022
@gbraad gbraad changed the title Onboarding onClose message gets shown after appStart happened Misleading message after changing preset Jan 21, 2022
@gbraad
Copy link
Contributor

gbraad commented Jan 26, 2022

but if the podman bundle is not available yet, crc setup will be needed.

Interesting to know how this is going to be messaged to the user. The tray/app needs to do the right thing too.

@gbraad gbraad closed this as completed Jan 28, 2022
Repository owner moved this from Ready for review to Done in Project planning Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@praveenkumar praveenkumar

Labels
preset/podman Issue with podman preset
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes Misc issue for dev branch praveenkumar/crc
3 participants
@gbraad @praveenkumar @cfergeau