Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lots of references to OpenShift when podman is used #2863

Closed
cfergeau opened this issue Nov 30, 2021 · 0 comments · Fixed by #2959
Closed

Lots of references to OpenShift when podman is used #2863

cfergeau opened this issue Nov 30, 2021 · 0 comments · Fixed by #2959
Assignees
@gbraad @praveenkumar @kowen-rh
Labels
preset/podman Issue with podman preset priority/major

Comments

@cfergeau
Copy link
Contributor

crc stop, crc delete, ... all mention an "OpenShift cluster", which is unexpected when using the podman preset.

The memory/cpu/... command line parameters also have such mentions.
@gbraad gbraad mentioned this issue Jan 11, 2022
Closed
6 tasks
@gbraad gbraad added the preset/podman Issue with podman preset label Jan 11, 2022
praveenkumar added a commit to praveenkumar/crc that referenced this issue Jan 19, 2022
@praveenkumar
Fix mismatch messaging during podman preset
3b22e17 
Currently most of the places still have `Openshift cluster` as part of
string and show as message to user when perform different operation like
`delete`, `setup` ..etc. This PR tries to fix it by using preset friendly
message string and show it to user as per preset.

fixes: crc-org#2863
@praveenkumar praveenkumar mentioned this issue Jan 19, 2022
Merged
praveenkumar added a commit to praveenkumar/crc that referenced this issue Jan 21, 2022
@praveenkumar
Fix mismatch messaging during podman preset
da3f2a8 
Currently most of the places still have `Openshift cluster` as part of
string and show as message to user when perform different operation like
`delete`, `setup` ..etc. This PR tries to fix it by using preset friendly
message string and show it to user as per preset.

fixes: crc-org#2863
@gbraad gbraad closed this as completed Jan 28, 2022
@gbraad gbraad moved this to Done in Project planning Jan 28, 2022
@gbraad gbraad reopened this Jan 28, 2022
@gbraad gbraad moved this from Done to In Progress in Project planning Jan 28, 2022
@gbraad gbraad linked a pull request Jan 28, 2022 that will close this issue
Fix mismatch messaging during podman preset #2959
Merged
praveenkumar added a commit to praveenkumar/crc that referenced this issue Feb 4, 2022
@praveenkumar
Fix mismatch messaging during podman preset
7b93e78 
Currently most of the places still have `Openshift cluster` as part of
string and show as message to user when perform different operation like
`delete`, `setup` ..etc. This PR tries to fix it by just using `instance`
instead of runtime.

fixes: crc-org#2863
praveenkumar added a commit to praveenkumar/crc that referenced this issue Feb 8, 2022
@praveenkumar
Fix mismatch messaging during podman preset
c3ac396 
Currently most of the places still have `Openshift cluster` as part of
string and show as message to user when perform different operation like
`delete`, `setup` ..etc. This PR tries to fix it by just using `instance`
instead of runtime.

fixes: crc-org#2863
praveenkumar added a commit to praveenkumar/crc that referenced this issue Feb 11, 2022
@praveenkumar
Fix mismatch messaging during podman preset
601844e 
Currently most of the places still have `Openshift cluster` as part of
string and show as message to user when perform different operation like
`delete`, `setup` ..etc. This PR tries to fix it by just using `instance`
instead of runtime.

fixes: crc-org#2863
praveenkumar added a commit to praveenkumar/crc that referenced this issue Feb 15, 2022
@praveenkumar
Fix mismatch messaging during podman preset
2352cdf 
Currently most of the places still have `Openshift cluster` as part of
string and show as message to user when perform different operation like
`delete`, `setup` ..etc. This PR tries to fix it by just using `instance`
instead of runtime.

fixes: crc-org#2863
praveenkumar added a commit to praveenkumar/crc that referenced this issue Feb 15, 2022
@praveenkumar
Fix mismatch messaging during podman preset
a549fe2 
Currently most of the places still have `Openshift cluster` as part of
string and show as message to user when perform different operation like
`delete`, `setup` ..etc. This PR tries to fix it by just using `instance`
instead of runtime.

fixes: crc-org#2863
praveenkumar added a commit that referenced this issue Feb 15, 2022
@praveenkumar
Fix mismatch messaging during podman preset
e2a76bb 
Currently most of the places still have `Openshift cluster` as part of
string and show as message to user when perform different operation like
`delete`, `setup` ..etc. This PR tries to fix it by just using `instance`
instead of runtime.

fixes: #2863
@gbraad gbraad moved this from In Progress to Done in Project planning Feb 15, 2022
@gbraad gbraad closed this as completed Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gbraad gbraad

@praveenkumar praveenkumar

@kowen-rh kowen-rh

Labels
preset/podman Issue with podman preset priority/major
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix mismatch messaging during podman preset praveenkumar/crc
4 participants
@gbraad @praveenkumar @cfergeau @kowen-rh