[BUG] crc and snc don't use the same routes-controller image

[cfergeau]

snc uses quay.io/crcont/routes-controller:${image_tag}
https://github.com/crc-org/snc/blob/4ada0a93e0e3de2b0fbd328ef43096c7563a7ed9/createdisk.sh#L79-L80

crc uses quay.io/crcont/routes-controller:latest

crc/pkg/crc/machine/start.go

Lines 835 to 844 in 3291661

	Spec: v1.PodSpec{
	ServiceAccountName: "router",
	Containers: []v1.Container{
	{
	Name: "routes-controller",
	Image: "quay.io/crcont/routes-controller:latest",
	ImagePullPolicy: v1.PullIfNotPresent,
	},
	},
	},

Not sure which one should be changed, the easiest would be to tag quay.io/crcont/routes-controller:${image_tag} as latest when pulling it in snc, but I'm not sure crictl supports setting tags.

[cfergeau]

I suspect because of this inconsistency crc pulls the routes-controller image from quay at cluster creation instead of reusing the cached one. If the cached image is still the latest one, it's not very important, but if the cached one is no longer also the latest, this is more problematic

[gbraad]

If the cached image is still the latest one, it's not very important,

inconsistencies like this can lead to hard to track issues. we can't assume these are both pointing to 'latest'. It would be better to use a tag that is identical on both ends.

[praveenkumar]

In case of openshift preset we should use the image tag as openshift_version since we are now building it for each openshift release and for podman preset we should use the latest tag.

Edit: looks like we don't need this image for podman preset and we might put this logic to the snc side and in crc side just create the deployment/pod.

[praveenkumar]

This is fixed by crc-org/snc@fe6a6d2

/close

[openshift-ci]

@praveenkumar: Closing this issue.

In response to this:

This is fixed by crc-org/snc@fe6a6d2

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.