Fix error when num of CPU not match progress bars #3781
Conversation
Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
evidolob
force-pushed
the
fix-cpu-bar-num-error
branch
from
f97f52f to
f1a3ce9
Compare
|
@evidolob: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
since @anjannath was ale to repro, please have a look |
| @@ -90,6 +90,14 @@ func runWatchStatus(writer io.Writer, client *daemonclient.Client, cacheDir stri | |||
| if err != nil { | |||
| return | |||
| } | |||
| } else if len(loadResult.CPUUse) > len(cpuBars) { | |||
There was a problem hiding this comment.
should we also consider the case when loadResult.CPUUse would be less then cpuBars which would occur if the user sets config option cpus with a value less then current, currently we have a stale or extra progress bar (fixed value and doesn't change) in this case.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anjannath The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes: Issue #3743
Solution/Idea
PR add check that sizes of
CPU'sload andCPU'sprogress bars are the same.If number CPU's is bigger then created
CPU'sprogress bars, it add missing bars.