Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test (e2e) : move manpage checks to a separate scenario (#4608) #4611

Merged
merged 1 commit into from
Feb 27, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions test/e2e/features/basic.feature
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ Feature: Basic test
* setting config property "enable-cluster-monitoring" to value "true" succeeds
* setting config property "memory" to value "16000" succeeds
Given executing single crc setup command succeeds
And executing "man -P cat crc" succeeds
When starting CRC with default bundle succeeds
Then stdout should contain "Started the OpenShift cluster"
# Check if user can copy-paste login details for developer and kubeadmin users
Expand Down Expand Up @@ -74,4 +73,3 @@ Feature: Basic test
And kubeconfig is cleaned up
# cleanup
When executing crc cleanup command succeeds
And executing "man -P cat crc" fails
58 changes: 58 additions & 0 deletions test/e2e/features/manpages.feature
Original file line number Diff line number Diff line change
@@ -0,0 +1,58 @@
@story_manpages
Feature: Check generation and cleanup of manpages

@linux @darwin
Scenario Outline: verify man pages are accessible after setup
Given executing single crc setup command succeeds
And executing "export MANPATH=$HOME/.local/share/man:$MANPATH" succeeds
Then executing "man -P cat 1 <crc-subcommand>" succeeds

@linux @darwin
Examples: Man pages to check
| crc-subcommand |
| crc |
| crc-bundle-generate |
| crc-config |
| crc-start |
| crc-bundle |
| crc-console |
| crc-status |
| crc-cleanup |
| crc-delete |
| crc-stop |
| crc-config-get |
| crc-ip |
| crc-version |
| crc-config-set |
| crc-oc-env |
| crc-config-unset |
| crc-podman-env |
| crc-config-view |
| crc-setup |

Scenario Outline: verify man pages are NOT accessible after cleanup
Given executing crc cleanup command succeeds
Then executing "man -P cat 1 <crc-subcommand>" fails

@linux @darwin
Examples: Man pages to check
| crc-subcommand |
| crc |
| crc-bundle-generate |
| crc-config |
| crc-start |
| crc-bundle |
| crc-console |
| crc-status |
| crc-cleanup |
| crc-delete |
| crc-stop |
| crc-config-get |
| crc-ip |
| crc-version |
| crc-config-set |
| crc-oc-env |
| crc-config-unset |
| crc-podman-env |
| crc-config-view |
| crc-setup |