Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

start.go: Set chronyd in manual mode #4631

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

praveenkumar
Copy link
Member

From 4.17 kubelet-dependency.target have chrony-wait-service as dependency which start the chrony service again in the VM and set the time back to normal which cause no cert rotation for cluster and test are failing.

This PR set the chrony conf to manual which prevent to update the VM time even restart of chronyd service.

Fixes: #4337

Dependency: crc-org/snc#1016

To test this try following

$ crc setup  -b https://storage.googleapis.com/crc-bundle/crc_libvirt_4.19.0-ec.2_amd64_1016.crcbundle
$ sudo timedatectl set-ntp off
$ sudo date -s '13 month'
$ CRC_DEBUG_ENABLE_STOP_NTP=true  ./crc start -b https://storage.googleapis.com/crc-bundle/crc_libvirt_4.19.0-ec.2_amd64_1016.crcbundle --log-level debug

From 4.17 kubelet-dependency.target have chrony-wait-service as
dependency which start the chrony service again in the VM and set
the time back to normal which cause no cert rotation for cluster
and test are failing.

This PR set the chrony conf to manual which prevent to update the VM
time even restart of chronyd service.
@openshift-ci openshift-ci bot requested review from cfergeau and evidolob February 19, 2025 07:03
Copy link

openshift-ci bot commented Feb 19, 2025

@praveenkumar: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-crc 2a1fdcc link true /test e2e-crc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link

openshift-ci bot commented Feb 19, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: albfan
Once this PR has been reviewed and has the lgtm label, please ask for approval from praveenkumar. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@praveenkumar praveenkumar merged commit cb1c6e6 into crc-org:main Feb 20, 2025
29 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Certificate rotation test failed
2 participants